Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use saturating math for hoursSinceArbitrum #2310

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

PlasmaPower
Copy link
Collaborator

After merging #2308 I realized it'd be better to be safe here, e.g. in case of eth_call block overrides

@PlasmaPower PlasmaPower requested a review from tsahee May 16, 2024 20:04
@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 16, 2024
@PlasmaPower PlasmaPower force-pushed the time-since-saturating branch from 310e83d to f301094 Compare May 16, 2024 20:17
@PlasmaPower PlasmaPower changed the title Use SaturatingUSub for hoursSinceArbitrum Use saturating math for hoursSinceArbitrum May 16, 2024
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower enabled auto-merge May 16, 2024 20:21
@PlasmaPower PlasmaPower merged commit d704e45 into master May 16, 2024
10 checks passed
@PlasmaPower PlasmaPower deleted the time-since-saturating branch May 16, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants